Add preliminary support for private dependencies using builtins.fetchGit #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this API looks like:
``` nix
buildGoApplication {
srcOverrides = self: super: {
"github.com/BurntSushi/toml" = super."github.com/BurntSushi/toml".override { private = true; };
};
}
```
Outstanding issues:
- Nix has issues dealing with short revs ( NixOS/nix#4694 )
- Param passing heuristics to fetchGit needs to be nailed down.
|
Nice! Think you might be able to incorporate some of #11 to resolve the full git rev/SHA? |
|
I have started looking at adding short rev support to Nix so we don't have to add any more metadata. |
|
Is this patch waiting for upstream changes? Is there any other work that needs doing to support private repos other than what is outlined in this PR? |
|
Hi, just bumping this up to see if there is any reply to the previous comment questions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add preliminary support for private dependencies using builtins.fetchGit
Using this API looks like:
Outstanding issues: