Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add npins #257

Merged
merged 2 commits into from
Oct 22, 2024
Merged

add npins #257

merged 2 commits into from
Oct 22, 2024

Conversation

phanirithvij
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Cynthia Fox <[email protected]>
Copy link
Member

@cyntheticfox cyntheticfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now. provided the linters pass, will merge

@phanirithvij
Copy link
Contributor Author

phanirithvij commented Oct 22, 2024

Can the linter workflow be made to run without maintainers approval?

@Mic92
Copy link
Member

Mic92 commented Oct 22, 2024

It's a repository setting. Since I don't expect too much spam on this repository probably a good idea.

@cyntheticfox cyntheticfox merged commit 91d4f1f into nix-community:main Oct 22, 2024
2 checks passed
@cyntheticfox
Copy link
Member

Afaict, you can't turn it off entirely, but I did loosen it to only require approval for first-time contributes with new github accounts (from all first-time contributors)

@phanirithvij phanirithvij deleted the patch-1 branch October 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants