Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Docker Desktop integration #545

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Update Docker Desktop integration #545

merged 4 commits into from
Sep 20, 2024

Commits on Sep 16, 2024

  1. docker-desktop: symlink required executables to /bin 

    Ensures that all executables required by Docker Desktop on Windows exist
in the default PATH of the WSL distribution.
    @antoineco
    antoineco committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8957811 View commit details
    Browse the repository at this point in the history

  2. docker-desktop: include xdg-utils system package 

    Compose links to Docker Desktop by opening 'docker-desktop://' URLs
through xdg-open.
    @antoineco
    antoineco committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c9b29fe View commit details
    Browse the repository at this point in the history

  3. docker-desktop: remove proxy service unit 

    Docker Desktop's WSL integration is able to start the proxy by itself
and to stop it upon shut down. Keeping a systemd unit under the
management of NixOS is not only unnecessary but also comes with its own
issues:

- We will ultimately have to play catch up with Docker Desktop whenever
  they change their flags.

- The service is running constantly, or worse, fails constantly when the
  docker-desktop instance is unavailable unless we add some better
  prerequisite detection to the unit.
    @antoineco
    antoineco committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fb3f37f View commit details
    Browse the repository at this point in the history

  4. docker-desktop: do not install docker{,-compose} 

    Docker Desktop comes with its own 'docker' and CLI plugin executables
already, including Compose. Docker Desktop symlinks those executables in
the /usr/bin directory of the WSL instance whenever it is up and removes
them when it shuts down.

If the user wants to install their own 'docker' program they are free to
do so, but it is by no means something that Docker Desktop requires.
    @antoineco
    antoineco committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1b63f13 View commit details
    Browse the repository at this point in the history