Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add certificate install instructions #543

Merged
merged 6 commits into from
Oct 13, 2024

Conversation

Rasmus-Bertell
Copy link
Contributor

Adds instructions to install the certificate if using the .msixbundle launcher.

Copy link

@malik-n malik-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really part of the scope of the install page?
It makes it look like Mixbundle would be part of the default path of installing NixOS-WSL even though I am still not quiet sure what Mixbundle is.

@Rasmus-Bertell
Copy link
Contributor Author

is this really part of the scope of the install page? It makes it look like Mixbundle would be part of the default path of installing NixOS-WSL even though I am still not quiet sure what Mixbundle is.

I think it's pretty crucial since the .msixbundle launcher can't be used, at least on some systems, without the certificate. I only knew how to install the certificate because I had done it previously for ArchWSL1. Another option in my opinion would be to link the ArchWSL docs on how to do it.

Footnotes

  1. https://wsldl-pg.github.io/ArchW-docs/Install-Certificate/

@malik-n
Copy link

malik-n commented Sep 13, 2024

is this really part of the scope of the install page? It makes it look like Mixbundle would be part of the default path of installing NixOS-WSL even though I am still not quiet sure what Mixbundle is.

I think it's pretty crucial since the .msixbundle launcher can't be used, at least on some systems, without the certificate. I only knew how to install the certificate because I had done it previously for ArchWSL1. Another option in my opinion would be to link the ArchWSL docs on how to do it.

Footnotes

  1. https://wsldl-pg.github.io/ArchW-docs/Install-Certificate/

Knowing how to setup msixbundle might be crucial if you are a user of that software. There is lots of software that might be crucial to some users.
I suggest to move that setup guide to /docs/src/how-to

@Rasmus-Bertell
Copy link
Contributor Author

Moved it into how-to section. Let me know if other changes are needed.

@malik-n
Copy link

malik-n commented Sep 16, 2024

Moved it into how-to section. Let me know if other changes are needed.

its not up to me
but I would aproove when you change the file name to something more specific

@nzbr
Copy link
Member

nzbr commented Oct 5, 2024

I think it's fine to keep it in the how-to section for now, as the default install method for most people will still be the tarball without the launcher

@nzbr nzbr added the documentation Improvements or additions to documentation label Oct 5, 2024
@nzbr nzbr merged commit 2454495 into nix-community:main Oct 13, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants