refactor: use node-mock-http instead of unenv v1 for local fetch
#3069
+47
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates direct fetch implementation from unenv v1 to node-mock-http.
This unblocks nitro v2 to migrate to unenv v2 which has breaking changes for HTTP (unjs/unenv#364).
One other benefit of
node-mock-httpis that it leverages Node.jsnode:bufferandnode:events(downside is temporary polyfill duplicate in environments without native Buffer/Events support -- cloudflare does support now)Complementry h3 (v1) PR: unjs/h3#970