Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase-app-hosting): use relative path in runCommand #2895

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Yuangwang
Copy link
Contributor

@Yuangwang Yuangwang commented Nov 19, 2024

🔗 Linked issue

Discussed on discord, needed to support frameworks that change the location of serverDir

(note by @pi0): this is a temporary solution to support AnalogJS until it changes back to nitro defaults in next major versions.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This addresses and issue where the hard coded runCommand doesn't work if the server directory location is changed

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Yuangwang Yuangwang requested a review from pi0 as a code owner November 19, 2024 18:23
src/presets/firebase/preset.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix(firebase-app-hosting): change preset to use relative server path in runCommand fix(firebase-app-hosting): use relative path in runCommand Nov 19, 2024
@pi0 pi0 merged commit 6c3d16e into nitrojs:v2 Nov 19, 2024
4 checks passed
@pi0
Copy link
Member

pi0 commented Nov 19, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants