Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flutter guide #608

Merged
merged 16 commits into from
Oct 22, 2024
Merged

add flutter guide #608

merged 16 commits into from
Oct 22, 2024

Conversation

HomelessDinosaur
Copy link
Member

@HomelessDinosaur HomelessDinosaur commented Aug 22, 2024

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nitric-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:38pm

@davemooreuws
Copy link
Member

Add to dart guides homepage.

Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a few touch ups and suggestions. I also noticed that calling an existing favorite breaks the api for me (unhandled exception).

Lastly, do we want "favourite" to be spelt "favorite" for US.

src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
src/pages/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
Copy link
Member

@raksiv raksiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, only one minor thing.

raksiv
raksiv previously approved these changes Sep 26, 2024
docs/guides/dart/flutter.mdx Outdated Show resolved Hide resolved
davemooreuws
davemooreuws previously approved these changes Oct 22, 2024
davemooreuws
davemooreuws previously approved these changes Oct 22, 2024
raksiv
raksiv previously approved these changes Oct 22, 2024
dictionary.txt Outdated Show resolved Hide resolved
Co-authored-by: Jye Cusch <[email protected]>
@HomelessDinosaur HomelessDinosaur merged commit bab5aad into main Oct 22, 2024
6 checks passed
@HomelessDinosaur HomelessDinosaur deleted the guide/flutter-blog branch October 22, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants