Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle unexpected nil conversion #32

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

nrwiersma
Copy link
Contributor

Goal of this PR

This fixes an issue where Terraform converts [""] into [nil] which was unexpected and paniced. The software now handles nils as the default value.

Checklist

Does the PR require tests to be added or updated?

Ideally PRs should include the tests to code they add, but if for some reason they do not, there should be a TODO
comment in the place where the test should be, linking to a GitHub issue that details what test should be written.

Misc

  • PR title is explicit
  • PR includes unit tests for the added code / regression tests for the fixed bugs
  • PR is against the correct branch (likely main)
  • PR is linked to an issue

@nrwiersma nrwiersma requested a review from antiphp January 27, 2025 14:45
@nrwiersma nrwiersma self-assigned this Jan 27, 2025
@nrwiersma nrwiersma merged commit 27b5bd9 into nitrado:main Jan 27, 2025
2 checks passed
@nrwiersma nrwiersma deleted the fix-panic branch January 27, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants