Add Nano Text Editor To Buildroot #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 964e2c9)
|
Sorry for the delay. This makes sense. We currently have Only concern how much size impact does it have on the image. Not that we have a super optimised image, but wouldn't want to bloat it. I don't think |
|
I personally only ever SSH'ed into it to edit config files. I can't speak about the size difference but from my understanding nano is very lightweight so you would assume it would be quite small too. I didn't notice any size difference when building the image locally. |
|
Merged. Thanks a lot! :) |
sondresjolyst
added a commit
to sondresjolyst/AAWirelessDongle
that referenced
this pull request
May 25, 2024
* Update README for the updated connection process * Update build.yml to upload combined artefact as well * Disable Bluetooth Device Identification * Add option to changes the usb/phone connection sequence (nisargjhaveri#56) Add option to change the initial connection. Set `AAWG_CONNECTION_WAIT_FOR_ACCESSORY` in `/etc/aawgd.env` to wait for the usb to connect first rather than connecting to the phone first. Co-authored-by: Nisarg Jhaveri <[email protected]> * Bump RPi Bluetooth and Wifi firmwares (nisargjhaveri#69) Fixes issues with Bluetooth and Wifi on some devices * Fix some spellings * Reduce logging verbosity, don't log every read/write until there might be an error * Add timeout for usb accessory start request and retry connection - In phone-first connection, the phone seems to have a 10s timeout for the TCP connection. - If usb takes more time than that, it will anyway fail to connect. - Add timeout for 10s to receive the usb accessory start request, if not restart the connection. * Retry bluetooth connection until TCP connection is established - This should be useful in the cases where the initial bluetooth connection fails. - Keep retrying the bluetooth connection until the TCP is connected. * Add small delay before enabling accessory usb gadget * Disconnect bluetooth device before retrying bluetooth connection * Add TCP read timeout, reliably stop forwarding by interrupting the threads (nisargjhaveri#90) - Add read timeout for the TCP connection to help detect wifi disconnection or other failures - When USB/TCP error is detected, interrupt the other thread to stop waiting on the read/write operation The interruption is required, especially for the usb read/right operations as it currently does not support poll/select. Fixes nisargjhaveri#26. * Improve logging, redirect console output from init scripts to syslog as well * Add execute permission for /etc/init.d/rcS * Add dongle mode connection strategy (nisargjhaveri#72) - Android Auto has native support to connecting Wireless AA via dongles. - With the dongle mode, we don't need to fake the HSP profile for connection. This results in better call audio routing. - With this, the phone waits for headunit's bluetooth to connect. This might help in cars where power to the dongle is started much before the headunit is ready. - Add config AAWG_CONNECTION_STRATEGY to choose other connection sequences. * Update README for dongle mode connection * Reduce verbosity of hostapd logs * Add Nano Text Editor To Buildroot (nisargjhaveri#104) * Increase bluetooth and usb connection timeouts --------- Co-authored-by: Nisarg Jhaveri <[email protected]> Co-authored-by: Ioniq3 <[email protected]> Co-authored-by: NabeelUppel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for editing config files from terminal