Test lima fix for running in background

With the fix[1] lima starts the hostagenet process in a new process group so we can run limactl normally as it should. When we terminate after errors limactl is terminated without harming the hostagenet process. The fix is available in upstream but not released yet. It should available in lima around October. [1] lima-vm/lima#2574 Signed-off-by: Nir Soffer <[email protected]>
nirs · Sep 1, 2024 · e6d40fe · e6d40fe
1 parent a58f4ea
commit e6d40fe
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/test/drenv/providers/lima/__init__.py b/test/drenv/providers/lima/__init__.py
@@ -13,7 +13,7 @@
 from drenv import kubeconfig
 from drenv import yaml
 
-LIMACTL = "limactl"
+LIMACTL = "/Users/nsoffer/src/lima/_output/bin/limactl"
 
 # Important lima statuses
 RUNNING = "Running"
@@ -234,15 +234,7 @@ def _create_cluster(profile, config):
 
 
 def _start_cluster(profile):
-    # Start limactl in a new process group to prevnet killing limactl hostagent on drenv shutdown.
-    # Should be fixed in lima, but this should be good enough for now.
-    _watch(
-        LIMACTL,
-        "start",
-        profile["name"],
-        context=profile["name"],
-        process_group=0,
-    )
+    _watch(LIMACTL, "start", profile["name"], context=profile["name"])
 
 
 def _stop_cluster(profile):