Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh, wip] adding cli with click (#297) #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Oct 8, 2020

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

  • adding cli with click (pydracli)
  • adding clean function to remove directories with .lock extension

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #364 into master will decrease coverage by 3.27%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   85.69%   82.42%   -3.28%     
==========================================
  Files          20       21       +1     
  Lines        3761     3778      +17     
  Branches     1016     1019       +3     
==========================================
- Hits         3223     3114     -109     
- Misses        339      463     +124     
- Partials      199      201       +2     
Flag Coverage Δ
#unittests 82.42% <52.94%> (-3.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/tools/click_main.py 52.94% <52.94%> (ø)
pydra/engine/boutiques.py 16.19% <0.00%> (-68.58%) ⬇️
pydra/engine/task.py 74.14% <0.00%> (-10.60%) ⬇️
pydra/engine/specs.py 84.74% <0.00%> (-2.18%) ⬇️
pydra/engine/helpers_file.py 77.30% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52a05b...a0b6665. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant