redo ExtractROI #47
Open
redo ExtractROI #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
we can talk more tomorrow, but I think |
|
yes, |
|
this should be finished after the issues is resolved: #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @djarecka , I redid
extractroiby changing the output basename from_trimto_roi. (passed pytest locally)(just a note from today's discussion) @effigies mentioned that we can set requirements for argstr that for each of x_min, x_size, y_min, y_size, z_min, z_size requires [x_min, x_size, y_min, y_size, z_min, z_size], then for t_min, t_size, requires [t_min, t_size]. We can manually do this.
our current converter has something called
input_dropslink, of which the usage can be found here. So it inherits thecrop_listfromnipypelet me know what we want to do with
extractroifurther.