Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo ExtractROI #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

redo ExtractROI #47

wants to merge 2 commits into from

Conversation

yibeichan
Copy link
Collaborator

Hi @djarecka , I redid extractroi by changing the output basename from _trim to _roi. (passed pytest locally)
(just a note from today's discussion) @effigies mentioned that we can set requirements for argstr that for each of x_min, x_size, y_min, y_size, z_min, z_size requires [x_min, x_size, y_min, y_size, z_min, z_size], then for t_min, t_size, requires [t_min, t_size]. We can manually do this.
our current converter has something called input_drops link, of which the usage can be found here. So it inherits the crop_list from nipype
let me know what we want to do with extractroi further.

@djarecka
Copy link
Contributor

djarecka commented May 9, 2023

we can talk more tomorrow, but I think input_drops works as intended here, right?

@yibeichan
Copy link
Collaborator Author

yes, input_drops generates the same list as the one in nipype see here. but in the morning, we were talking about x_min, x_size, require y_min, y_size, z_min, z_size; t_min & t_size require each other. this sort of requirement is not in our current extractroi, if we want it, we have to manually define it.

@djarecka
Copy link
Contributor

this should be finished after the issues is resolved: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants