fixing defaults for function interfaces

nipype · May 29, 2024 · caee1bc · caee1bc
1 parent c97e489
commit caee1bc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/nipype2pydra/interface/base.py b/nipype2pydra/interface/base.py
@@ -575,7 +575,7 @@ def pydra_fld_input(self, field, nm):
 
         pos = pydra_metadata.get("position", None)
 
-        if pydra_default is not None and not pydra_metadata.get("mandatory", None):
+        if pydra_default is not None:  # and not pydra_metadata.get("mandatory", None):
             return (pydra_type, pydra_default, pydra_metadata), pos
         else:
             return (pydra_type, pydra_metadata), pos

diff --git a/nipype2pydra/interface/function.py b/nipype2pydra/interface/function.py
@@ -105,7 +105,14 @@ def types_to_names(spec_fields):
         spec_str += ", ".join(f"'{n}': {t}" for n, t, _ in output_fields_str)
         spec_str += "}})\n"
         spec_str += f"def {self.task_name}("
-        spec_str += ", ".join(f"{i[0]}: {i[1]}" for i in input_fields_str)
+        spec_str += ", ".join(
+            (
+                f"{i[0]}: {i[1]} = {i[2]!r}"
+                if len(i) == 4
+                else f"{i[0]}: {i[1]} = attrs.NOTHING"
+            )
+            for i in input_fields_str
+        )
         spec_str += ")"
         if output_type_names:
             spec_str += "-> "