tridisolve not accesible #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using your library and I found it a little bit slow. Diving into the code, I discovered that line (884) in "utils.py" that was trying to import the cythonized module _utils but was unreachable. I just added the dot before the import and the import was successful. I don't know if the dot is only in my case, (venv virtual environment, VSCode, amd64 Windows) or if it's a general fix but I feel that I had to propose changes
arokem
reviewed
Feb 14, 2024
|
Hi, i am in the same situation as @temisAP, i changed "from _utils import" to "from nitime._utils import" and i have a gain of time in my use of the library (in my case on Kubuntu 22.04.2). Could this pull request be merged ? In order to have this in the next release of nitime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using your library and I found it a little bit slow. Diving into the code, I discovered that line (884) in "utils.py" that was trying to import the cythonized module _utils but was unreachable. I just added the dot before the import and the import was successful. I don't know if the dot is only in my case, (venv virtual environment, VSCode, amd64 Windows) or if it's a general fix but I feel that I had to propose changes