Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Missed np.savetxt bstring #3704

Merged
merged 1 commit into from
Dec 17, 2024
Merged

FIX: Missed np.savetxt bstring #3704

merged 1 commit into from
Dec 17, 2024

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Dec 17, 2024

Popped up in tests - remaining from b41fb1c

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.04%. Comparing base (37546c7) to head (292e35c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
nipype/algorithms/confounds.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3704      +/-   ##
==========================================
- Coverage   73.13%   73.04%   -0.09%     
==========================================
  Files        1278     1278              
  Lines       59356    59356              
==========================================
- Hits        43411    43359      -52     
- Misses      15945    15997      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

Should we release with this?

@effigies effigies merged commit 8b78870 into nipy:master Dec 17, 2024
25 checks passed
@mgxd mgxd deleted the fix/np-save branch December 17, 2024 17:09
@effigies effigies mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants