Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted variable names for clarity and codespell false positives #3627

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

TheChymera
Copy link
Collaborator

Codespell currently fails due to false positive detection of “inports”, which are input ports and not a misspelling of imports.
Also makes the code more clear I think.

@TheChymera
Copy link
Collaborator Author

Not sure the same sort of fix is good for “expad” (similarly ex-padding), because that's a verbatim parameter for AFNI... probably not a good idea to introduce an underscore there.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5ef9fe4) 63.15% compared to head (71e8795) 63.15%.

Files Patch % Lines
nipype/pipeline/engine/utils.py 78.94% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3627    +/-   ##
========================================
  Coverage   63.15%   63.15%            
========================================
  Files         308      308            
  Lines       40825    40825            
  Branches     5656     5500   -156     
========================================
  Hits        25781    25781            
  Misses      14031    14031            
  Partials     1013     1013            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheChymera TheChymera requested a review from effigies January 23, 2024 16:58
@effigies effigies merged commit 42302ed into nipy:master Feb 6, 2024
17 of 18 checks passed
@TheChymera TheChymera deleted the codespell branch February 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants