Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Enforce ruff/flake8-comprehensions rules (C4) #1353

Merged
merged 5 commits into from
Sep 22, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (9438297) to head (a28ce64).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files         207      207           
  Lines       29507    29507           
  Branches     4982     4980    -2     
=======================================
  Hits        28134    28134           
  Misses        932      932           
  Partials      441      441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #1352 is in and merge conflicts are addressed.

C406 Unnecessary `list` literal (rewrite as a `dict` literal)
C413 Unnecessary `list` call around `sorted()`
C416 Unnecessary `dict` comprehension (rewrite using `dict()`)
C419 Unnecessary list comprehension
@effigies effigies merged commit 4c216b1 into nipy:master Sep 22, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants