Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add 3.13-nogil build #1339

Merged
merged 5 commits into from
Jul 12, 2024
Merged

CI: Add 3.13-nogil build #1339

merged 5 commits into from
Jul 12, 2024

Conversation

effigies
Copy link
Member

@effigies effigies commented Jul 11, 2024

Closes #1322.

This initial job installs and tests:

We do not currently test:

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (08f5c44) to head (880e13e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1339      +/-   ##
==========================================
+ Coverage   95.32%   95.34%   +0.02%     
==========================================
  Files         207      207              
  Lines       29084    29084              
  Branches     4863     4863              
==========================================
+ Hits        27724    27730       +6     
+ Misses        927      923       -4     
+ Partials      433      431       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the ci/py313 branch 2 times, most recently from f744830 to 28baf5f Compare July 11, 2024 01:35
@effigies
Copy link
Member Author

effigies commented Jul 11, 2024

Looks like we're correctly pulling in the cp313t wheel:

Collecting numpy>=2.1.dev0
  Downloading https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/numpy/2.1.0.dev0/numpy-2.1.0.dev0-cp313-cp313t-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (19.2 MB)

But the GIL is being enabled:

<frozen importlib._bootstrap>:488: RuntimeWarning: The global interpreter lock (GIL) has been enabled to load module 'numpy._core._multiarray_umath', which has not declared that it can run safely without the GIL. To override this behavior and keep the GIL disabled (at your own risk), run with PYTHON_GIL=0 or -Xgil=0.

Setting PYTHON_GIL=0 for py313 tests.

@effigies
Copy link
Member Author

@larsoner Does this all look reasonable to you? With numpy 2.0 released, I've switched the dev build to target 3.13+numpy 2.1.dev0.

@effigies effigies merged commit beb4f7b into nipy:master Jul 12, 2024
49 checks passed
@effigies effigies deleted the ci/py313 branch July 12, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add free-threaded CI build
1 participant