Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13: Account for dedented docstrings #1315

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

penguinpee
Copy link
Contributor

- Dedent docstrings in Python 3.13+
- Fix nipy#1311
- Ref: python/cpython#81283
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.23%. Comparing base (e5cd0e8) to head (9fa116b).

Files Patch % Lines
nibabel/deprecator.py 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   92.26%   92.23%   -0.03%     
==========================================
  Files          99       99              
  Lines       12472    12479       +7     
  Branches     2566     2568       +2     
==========================================
+ Hits        11507    11510       +3     
- Misses        642      645       +3     
- Partials      323      324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

effigies commented Apr 2, 2024

This looks good. Would you mind building the docs with 3.13 and taking a screenshot of a deprecated function? onetime.setattr_on_read should work.

@penguinpee
Copy link
Contributor Author

Well, this was a painful ask seeing that the top level Makefile still references setup.py which has been removed more than a year ago. It even calls sutup.py build. Ouch!

Anyway, I hope this is what you were asking for:

nibabel onetime setattr_on_read

If not, let me know. I have the entire HTML docs build with Python 3.13 available now.

@effigies
Copy link
Member

effigies commented Apr 2, 2024

Sorry, I always use make -C doc html, so I don't often notice problems in the top-level Makefile.

Thanks for going to the effort, that looks good to me.

@effigies effigies merged commit b5fad52 into nipy:master Apr 2, 2024
50 of 52 checks passed
@penguinpee
Copy link
Contributor Author

Sorry, I always use make -C doc html, so I don't often notice problems in the top-level Makefile.

Well, I was just following the instructions. PR #1316 will make sure other users like me have a less painful experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two tests are failing in 5.2.1 with Python 3.13.0a5
2 participants