Support AppKit #351
Open
Support AppKit #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| #endif | ||
|
|
||
| extension NSUIView { | ||
| var _layer: CALayer? { |
There was a problem hiding this comment.
Variable name should only contain alphanumeric characters: '_layer'
| } | ||
|
|
||
| func collectionView(_ collectionView: NSCollectionView, itemForRepresentedObjectAt indexPath: IndexPath) -> NSCollectionViewItem { | ||
| let viewItem = collectionView.makeItem(withIdentifier: .init(String(describing: CollectionViewItem.self)), for: indexPath) as! CollectionViewItem |
There was a problem hiding this comment.
Force casts should be avoided.
| @main | ||
| class AppDelegate: NSObject, NSApplicationDelegate { | ||
|
|
||
|
|
There was a problem hiding this comment.
Lines should not have trailing whitespace.
| } | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Files should have a single trailing newline.
| circle.frame = frame | ||
| circle.add(groupAnimation, forKey: "animation") | ||
| layer.addSublayer(circle) | ||
| } | ||
| } | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Files should have a single trailing newline.
|
Code Climate has analyzed commit 21a4a0d and detected 23 issues on this pull request. Here's the issue category breakdown:
Note: there are 2 critical issues. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some modifications to make it work in AppKit as well and have the same effect as iOS and MacCatalyst, and added example programs.