Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack crafting checks need to check bounds instead of turf to see if the location is acceptable. #85

Open
kriskog opened this issue Dec 6, 2019 · 3 comments
Labels
Complex A tricky problem that needs work in many places or complete overhauls

Comments

@kriskog
Copy link

kriskog commented Dec 6, 2019

If you make a 1x1 plating in space and try to build a locker, you need to be close to the center of the turf or it will tell you it needs a floor. This is despite having enture player sprite within the turf boundaries, ie here
image

@ninjanomnom
Copy link
Owner

This is probably an issue with it only checking the true loc instead of all locs when you're in multiple tiles

@ninjanomnom ninjanomnom added Required Needed before we can even testmerge Simple Var edits or just plain code deletion required to fix labels Dec 6, 2019
@ninjanomnom
Copy link
Owner

ninjanomnom commented Dec 6, 2019

Nevermind, this should be fixed in a more generic way by (not) allowing overlap of the bounds. Which is a bit more like a minor refactor of stack recipes

@ninjanomnom ninjanomnom added Complex A tricky problem that needs work in many places or complete overhauls and removed Simple Var edits or just plain code deletion required to fix labels Dec 6, 2019
@ninjanomnom ninjanomnom changed the title Crafting floor requirement is too strict Stack crafting checks need to check bounds instead of turf to see if the location is acceptable. Dec 6, 2019
@ninjanomnom
Copy link
Owner

ninjanomnom commented Dec 12, 2019

This needs larger changes and improvements to construction in general which I'm hesitant to do in the initial release. This is fine for now

@ninjanomnom ninjanomnom removed the Required Needed before we can even testmerge label Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complex A tricky problem that needs work in many places or complete overhauls
Projects
None yet
Development

No branches or pull requests

2 participants