Store cuePoints across page loads #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, you don't need to set your cue points again and again.
stianjensen
requested changes
Jul 3, 2023
| 'renin:stored', | ||
| JSON.stringify({ | ||
| frame: this.frame, | ||
| cuePoints: this.cuePoints.length > 0 ? this.cuePoints : null, |
There was a problem hiding this comment.
This PR only stores cuePoints, but doesn't read them?
| @@ -638,6 +643,13 @@ export class Renin { | |||
| if (this.options.productionMode) { | |||
| return false; | |||
| } | |||
| localStorage.setItem( | |||
There was a problem hiding this comment.
How often is this function called – will this localStorage add a noticeable penalty on the update loop in dev mode? 🤔
|
I'd love to get this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store cuePoints across page loads
This way, you don't need to set your cue points again and again.