added table html javascript placeholders and Column url_name for href link #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before_js and after_js are javascript placeholders that allow derived tables to add useful features to manage and format the datatable, like row highlight and so, thus avoiding placing them repeatedly in each template.
added to Column: url_name is a string that identifies a name of a url that will be accessible from the link href cell column two formats: 1/ url_name=some_link or 2/ url_name=somelink:field_name field_name (default is id) is the queryset field name whose value is used to format the href link
|
Thanks for the pull request. I haven't had much time to work on this project lately. I'm leaning toward your url_name parameter being part of a separate Column subclass (e.g. LinkColumn), but otherwise I like the idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added to Column: url_name
added to table.html: before_js and after_js