Remove now unused Overlay component #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Overlay component is not used in the create flow or anywhere else anymore since USDC support was merged (PR #465), and is incompatible with the changes in the iOS pointer-events bug fix (PR #470), where pointer-events were enabled on the overlay-frame when they shouldn't. The incompatibility does not show directly anymore since PR #465 was merged, but showed on the master branch before PR #465 that PR #470 was originally targeting.
sisou
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Overlay component is not used in the create flow or anywhere else anymore since USDC support was merged (PR #465), and is incompatible with the changes in the iOS pointer-events bug fix (PR #470), where pointer-events were enabled on the
overlay-framewhen they shouldn't. The incompatibility does not show directly anymore since PR #465 was merged, but showed on the master branch before PR #465 that PR #470 was originally targeting.