Skip to content

Commit

Permalink
Merge pull request #146 from nimblehq/release/1.4.0
Browse files Browse the repository at this point in the history
Release 1.4.0
  • Loading branch information
luongvo committed Feb 2, 2023
2 parents 4e2d58d + 5fee81d commit 461a444
Show file tree
Hide file tree
Showing 8 changed files with 85 additions and 49 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Team
# @manh-t is the Team Lead
# @luongvo is the Team Lead
* @manh-t @doannimble @luongvo @markgravity

# Engineering Leads
Expand Down
7 changes: 6 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
https://github.com/nimblehq/flutter_templates/issues/??
Note: for a release PR, append this parameter `?template=release_template.md` to the current URL to apply the release PR
template, e.g. `{Github PR URL}?template=release_template.md`

--

- Solves #

## What happened 👀

Expand Down
12 changes: 6 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE/release_template.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
Link to the milestone on Github e.g. https://github.com/nimblehq/flutter_templates/milestone/41?closed=1
or Link to the project management tool for the release
https://github.com/nimblehq/flutter_templates/milestone/?

## Features

Provide the ID and title of the issue in the section for each type (feature, chore and bug). The link is optional.

- [#1] As a user, I can log in or
- [[#1](https://github.com/nimblehq/flutter_templates/issues/1)] As a user, I can log in
- #

## Chores
- Same structure as in ## Feature

- #

## Bugs
- Same structure as in ## Feature

- #
20 changes: 20 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,23 @@ jobs:

- name: Set new project
run: make run PACKAGE_NAME=co.nimblehq.flutter.template PROJECT_NAME=flutter_templates APP_NAME="Flutter Templates"

- uses: subosito/flutter-action@v1
with:
channel: 'stable' # 'dev', 'alpha', default to: 'stable'
flutter-version: '3.3.10'

- name: Get flutter dependencies.
run: flutter pub get

- name: Run code generator
run: flutter packages pub run build_runner build --delete-conflicting-outputs

- name: Check for any formatting issues in the code.
run: flutter format --set-exit-if-changed .

- name: Statically analyze the Dart code for any errors.
run: flutter analyze .

- name: Run widget tests, unit tests.
run: flutter test --machine --coverage
2 changes: 1 addition & 1 deletion .template/.github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: subosito/flutter-action@v1
with:
channel: 'stable' # 'dev', 'alpha', default to: 'stable'
flutter-version: '2.10.3'
flutter-version: '3.3.10'

- name: Get flutter dependencies.
run: flutter pub get
Expand Down
7 changes: 7 additions & 0 deletions .template/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,10 @@ linter:

# Additional information about this file can be found at
# https://dart.dev/guides/language/analysis-options

analyzer:
exclude: [
lib/**.g.dart,
lib/**.freezed.dart,
test/**.mocks.dart
]
2 changes: 1 addition & 1 deletion .template/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.3.1+13
version: 1.4.0+14

environment:
sdk: ">=2.17.5 <3.0.0"
Expand Down
82 changes: 43 additions & 39 deletions scripts/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def move_project_to_root(project):
cur_dir = os.getcwd()
shutil.copytree(project.project_path, cur_dir, copy_function=shutil.move, dirs_exist_ok=True)

def clean_up(files: list[str]):
def clean_up(files):
cur_dir = os.getcwd()
for file in files:
file_path = cur_dir + os.sep + file
Expand All @@ -402,41 +402,45 @@ def clean_up(files: list[str]):
os.remove(file_path)

if __name__ == "__main__":
args = handleParameters()

project = Project(
args.project_path,
args.package_name,
args.app_name,
args.project_name,
args.app_version,
args.build_number
)
validate_parameters(project)

if os.environ.get("CI") != "true":
options = {
'none': 'none',
'kebab (kebab-case)': 'kebab',
'snake (snake_case)': 'snake',
'pascal (PascalCase)': 'pascal'
}
choice = enquiries.choose('Choose default json_serializable.field_rename: ', options.keys())
project.json_serializable = JsonSerializable(options[choice])
else:
# Skip enquiries on CI
project.json_serializable = JsonSerializable('snake')

print(f"=> 🐢 Starting init {project.new_project_name} with {project.new_package}...")
android = Android(project)
android.run()
ios = Ios(project)
ios.run()
flutter = Flutter(project)
flutter.run()
print('🤖 Generating project...')
# Remove the `.github` folder to avoid redundant workflow
clean_up(['.github'])
move_project_to_root(project)
clean_up(['.template', 'LICENSE', 'Makefile'])
print("=> 🚀 Done! Project is ready for the next development 🙌")
try:
args = handleParameters()

project = Project(
args.project_path,
args.package_name,
args.app_name,
args.project_name,
args.app_version,
args.build_number
)
validate_parameters(project)

if os.environ.get("CI") != "true":
options = {
'none': 'none',
'kebab (kebab-case)': 'kebab',
'snake (snake_case)': 'snake',
'pascal (PascalCase)': 'pascal'
}
choice = enquiries.choose('Choose default json_serializable.field_rename: ', options.keys())
project.json_serializable = JsonSerializable(options[choice])
else:
# Skip enquiries on CI
project.json_serializable = JsonSerializable('snake')

print(f"=> 🐢 Starting init {project.new_project_name} with {project.new_package}...")
android = Android(project)
android.run()
ios = Ios(project)
ios.run()
flutter = Flutter(project)
flutter.run()
print('🤖 Generating project...')
# Remove the `.github` folder to avoid redundant workflow
clean_up(['.github'])
move_project_to_root(project)
clean_up(['.template', 'LICENSE', 'Makefile'])
print("=> 🚀 Done! Project is ready for the next development 🙌")
except:
print("❌ There is something wrong! Please try again.")
sys.exit()

0 comments on commit 461a444

Please sign in to comment.