fixes #1203; if expressions contains return causes error in Hexer #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jun 19, 2025
| dest.addSymUse v, info | ||
|
|
||
| var rest = beginRead(tar.t) | ||
| if isNoReturn(rest): |
There was a problem hiding this comment.
Makes no sense to me. It's xelim's job to eradicate ExprX nodes. isNoReturn doesn't matter for this.
There was a problem hiding this comment.
proc foo =
var x = if true:
1
else:
returnxelim insert an assignment for return here
var tmp: int
if true:
(asgn tmp 1)
else:
(asgn tmp (ret))
Shouldn't we leave it alone for the noreturn branch? i.e.
var tmp: int
if true:
(asgn tmp 1)
else:
(ret)There was a problem hiding this comment.
correct but shouldn't the criterion be "expression has type void"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1203
If it is an
ExprXending with anoreturnstatement, we should leave it alone