keep order of provided object constructor fields in sem #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
changed the title
|
Ended up not fully fixing the issue, could close and postpone this for compat mode. |
|
I think sem should produce a warning or an error if there are function calls involved and the order of the fields differs from the declaration order. I don't see the benefit in allowing an arbitrary order in 2025 when auto-completion is now so good it threatens our jobs anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1056 (for the sem issue, evaluation order is still not fixed)
The compiler reorders the fields of an object constructor depending on the field order of the object type, this PR makes it so that provided fields are kept in the order that they were provided and only the default fields keep the object type order. This still encounters UB in the generated C so it doesn't fix the evaluation order, but it might still be useful, and things like:
won't break on resem.