-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cbuilder for tuple/object generation #24145
Conversation
Correct, but this will be done much later, the goal for now is tiny refactorings that keep the CI clean at all time until we're confident enough that we can replace the implementation with something else. |
331d2af
to
5a97124
Compare
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
based on #24127
Needs some tweaks to replace the other
struct
type generations, e.g. seqs, maybe by exposingBaseTypeKind
as a parameter. C++ and codegenDecl etc seem like they are going to need attention.Also
Builder
should really bedistinct string
that one has to callextract
on, but for this to be optimal in the current codegen, we would need something like:but this could be a separate PR since it might not work with the compiler. The possibly-not-optimal alternative is to do:
where the compiler maybe copies the built string but shouldn't.