Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes 22479; WIP [backport] #23718

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

fixes 22479; WIP [backport] #23718

wants to merge 3 commits into from

Conversation

Araq
Copy link
Member

@Araq Araq commented Jun 13, 2024

No description provided.

@metagn
Copy link
Collaborator

metagn commented Nov 4, 2024

Maybe generic aliases still need to be skipped, similar to what is done here:

Nim/compiler/types.nim

Lines 1955 to 1963 in f98964d

of tyGenericInvocation, tyGenericInst:
result = t
# skip aliases, so this works in the same module but not in another module:
# type Foo[T] = object
# type Bar[T] = Foo[T]
# proc foo[T](x: Bar[T]) = ... # attached to type
while result.skipModifier.kind in {tyGenericInvocation, tyGenericInst}:
result = result.skipModifier
result = nominalRoot(result[0])

skipGenericAlias which sighashes uses has the problem that it only skips 1 alias.

The CI run is gone so I can't say for sure this was the only problem.

@Araq
Copy link
Member Author

Araq commented Nov 4, 2024

Feel free to take over my work, it's a very important bug to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants