add back enum ident inference, only on undeclared identifiers #23614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23611, refs #23588
This adds back the enum identifier inference removed in #23588 but altered so that it only triggers when no symbol in scope with the same name is found. This is just to prevent further breakage while not causing bugs as the old behavior did (however #23596 still needs #23597 to work with this). Otherwise this behavior was never documented and only introduced in 1.6.14.
There are still some cases that would compile with the old behavior but not with this, such as the case where the symbol is found in scope but does not match with the enum type:
We could maybe make this work but it would be even more complexity for the compiler that was never promised.