Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #23499; don't skip addr when constructing bracketExpr #23503

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Apr 15, 2024

fixes #23499

In the 8990626 the effect of skipAddr changed to skip nkAddr and nkHiddenAddr. Some old code was not adapted. In the #23477, the magic addr function was handled in the semantic analysis phase, which causes it be skipped incorrectly

@ringabout
Copy link
Member Author

/home/runner/.nimble/pkgs2/arraymancer-0.7.28-d4a45ada1c7a6abebe60bcdd5ee2d7c4680799a4/arraymancer/tensor/private/p_accessors.nim(229, 50) Error: undeclared identifier: 't2data`gensym212'; if declared in a template, this identifier may be inconsistently marked inject or gensym

Unrelated CI failures

@Araq Araq merged commit 549ef24 into devel Apr 15, 2024
19 of 22 checks passed
@Araq Araq deleted the pr_addr_brancket branch April 15, 2024 15:28
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 549ef24

Hint: mm: orc; opt: speed; options: -d:release
178475 lines; 8.271s; 752.285MiB peakmem

@Vindaar
Copy link
Contributor

Vindaar commented Apr 15, 2024

/home/runner/.nimble/pkgs2/arraymancer-0.7.28-d4a45ada1c7a6abebe60bcdd5ee2d7c4680799a4/arraymancer/tensor/private/p_accessors.nim(229, 50) Error: undeclared identifier: 't2data`gensym212'; if declared in a template, this identifier may be inconsistently marked inject or gensym

Unrelated CI failures

I just tagged a new arraymancer version. That should fix the CI failures here and elsewhere. Relevant PR that fixes it on the arraymancer side should be @metagn's mratsim/Arraymancer#642.

metagn added a commit to metagn/Nim that referenced this pull request Apr 16, 2024
Was introduced to handle a break in nim-lang#23392, according to nim-lang#23503 (comment) should not be needed anymore
ringabout pushed a commit that referenced this pull request Apr 17, 2024
Was introduced to handle a break in #23392, according to
#23503 (comment)
should not be needed anymore
narimiran pushed a commit that referenced this pull request May 24, 2024
Was introduced to handle a break in #23392, according to
#23503 (comment)
should not be needed anymore

(cherry picked from commit 49e1ca0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression when using the volatile module on devel
3 participants