Merge pull request #113 from makeey/master

Do not filter values in AbstractCreationalQuery
nilportugues · Apr 7, 2020 · b00877e · b00877e
2 parents 8991871 + c81d63d
commit b00877e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 6 deletions.
diff --git a/src/Manipulation/AbstractCreationalQuery.php b/src/Manipulation/AbstractCreationalQuery.php
@@ -50,12 +50,7 @@ public function getValues()
      */
     public function setValues(array $values)
     {
-        $this->values = \array_filter($values, function($value) {
-            if (is_int($value)) {
-                return true;
-            }
-            return $value;
-        });
+        $this->values = $values;
 
         return $this;
     }

diff --git a/tests/Manipulation/InsertTest.php b/tests/Manipulation/InsertTest.php
@@ -62,4 +62,16 @@ public function itShouldGetColumns()
 
         $this->assertInstanceOf('NilPortugues\Sql\QueryBuilder\Syntax\Column', $columns[0]);
     }
+
+    /**
+     * @test
+     */
+    public function itShouldSetNullableValues()
+    {
+        $values = ['user_id' => 1, 'description' => null, 'isVisible' => false];
+
+        $this->query->setValues($values);
+
+        $this->assertSame($values, $this->query->getValues());
+    }
 }
diff --git a/tests/Manipulation/UpdateTest.php b/tests/Manipulation/UpdateTest.php
@@ -58,4 +58,16 @@ public function itShouldReturnValues()
 
         $this->assertSame($values, $this->query->getValues());
     }
+
+    /**
+     * @test
+     */
+    public function itShouldSetNullableValues()
+    {
+        $values = ['user_id' => 1, 'description' => null, 'isVisible' => false];
+
+        $this->query->setValues($values);
+
+        $this->assertSame($values, $this->query->getValues());
+    }
 }