Skip to content

Improve README syntax #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Improve README syntax #3

merged 1 commit into from
Mar 7, 2021

Conversation

mihaigalos
Copy link
Contributor

@mihaigalos mihaigalos commented Mar 6, 2021

Hi, nice work.
Here are some minor improvements.

Also, which branch are you referring to in this paragraph?- always a good idea to provide a ref.

This currently requires a special branch of rules_rust until it is accepted and merged into the original rules.

I saw your fork before producing this PR, but don't want to reference an upstream PR unless sure it is the one, since cannot un-reference afterwards.

If the required branch had been merged, I can tidy up even more.

@mihaigalos mihaigalos changed the title Improve syntax Improve README syntax Mar 6, 2021
@mihaigalos
Copy link
Contributor Author

mihaigalos commented Mar 6, 2021

Also, any plans to contribute this repo upstream to rules_rust?

@nikhilm
Copy link
Owner

nikhilm commented Mar 7, 2021

This is the relevant PR bazelbuild/rules_rust#421, but it has been stalled due to me not having the time/energy to fix the "recursive" build rule issue.

@nikhilm nikhilm merged commit e3bf8e4 into nikhilm:master Mar 7, 2021
@nikhilm
Copy link
Owner

nikhilm commented Mar 7, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants