Update fields in fit!

nignatiadis · Jul 11, 2017 · 3cf46c0 · 3cf46c0
1 parent e83f162
commit 3cf46c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/SmoothingSplines.jl b/src/SmoothingSplines.jl
@@ -66,7 +66,7 @@ function fit!{T<:LAPACKFloat}(spl::SmoothingSpline{T})
 end
 
 function fit!{T<:LAPACKFloat}(spl::SmoothingSpline{T}, Y::AbstractVector{T})
-    spl.Y = Y[spl.idx]
+    spl.Yorig = Y[spl.Xrank]
     fit!(spl)
 end
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -60,6 +60,11 @@ spl = fit(SmoothingSpline, X, Y, 1.0)
 
 @test predict(spl,X) ≈ predict(spl)
 
+# test explicitly setting the original values
+fit!(spl, Y)
+
+@test predict(spl,X) ≈ predict(spl)
+
 println("testing against smooth.spline on R cars dataset")
 # real data examples
 # cars dataset