code review comment

nightwatchjs · Oct 3, 2024 · 1992c47 · 1992c47
1 parent 5a47d31
commit 1992c47
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/nightwatch/globals.js b/nightwatch/globals.js
@@ -295,15 +295,11 @@ module.exports = {
     try {
       testObservability.configure(settings);
       if (helper.isTestObservabilitySession()) {
-        if (settings.reporter_options) {
-          if (settings.reporter_options['save_command_result_value'] != true){
-            settings.reporter_options['save_command_result_value'] = true
-          }
-        } else {
-          settings.reporter_options = {
-            save_command_result_value: true
-          }
-        }
+        // adding settings.reporter_options.save_command_result_value = true to ensure screenshot reporting to Observability
+        settings.reporter_options = {
+          save_command_result_value: true,
+          ...(settings.reporter_options || {})
+        };
         if (helper.isCucumberTestSuite(settings)) {
           cucumberPatcher();
           process.env.CUCUMBER_SUITE = 'true';