Update Insulin Peak Time

[tmhastings]

Correct identifications of Ultra-rapid and Rapid-acting insulins in the Insulin Peak Time Popup

[snickerdoodleparent]

Refer: PR347

Does this need an update to localize strings to show up in the pop-up in the app? Line 2034

Suggest:

/* "Insulin Peak Time" */
"Time of maximum blood glucose lowering effect of insulin, in minutes. Beware: oref assumes for ultra-rapid (Lyumjev, Fiasp) & rapid-acting (Humalog, Novolog, Apidra) curves minimum (35 & 50 min) and maximum (100 & 120 min) applicable insulinPeakTimes. Using a custom insulinPeakTime outside these bounds will result in issues with Trio, longer loop calculations and possible red loops." = "Time of maximum blood glucose lowering effect of insulin, in minutes. Beware: oref assumes for ultra-rapid (Lyumjev, Fiasp) & rapid-acting (Humalog, Novolog, Apidra) curves minimum (35 & 50 min) and maximum (100 & 120 min) applicable insulinPeakTimes. Using a custom insulinPeakTime outside these bounds will result in issues with Trio, longer loop calculations and possible red loops.";

Novolog is used in Loop. In some places (Canada, for one) it's referred to as Novorapid.

Not sure about the timing.

[MikePlante1]

Does this need an update to localize strings to show up in the pop-up in the app? Line 2034

To show in the app, the change needs to be added to PreferencesEditorStateModel.swift#L382 and in order for localizations to work, all 23 Localizable.strings files need to be updated. Otherwise all translated apps would just show the untranslated text from PreferencesEditorStateModel.swift

---

Novolog is used in Loop. In some places (Canada, for one) it's referred to as Novorapid.

Not sure about the timing.

The options for insulin in Trio come from Loop and are Apidra, Humalog, Novolog, Fiasp, and Lyumjev... so I think it's best to just leave this tooltip as Novolog. I do think it could be beneficial to update the description in LoopKit in InsulinType.swift as well as all 11 Localizable.strings for LoopKit

I'd suggest something like:

NovoLog (insulin aspart) is a rapid-acting insulin made by Novo Nordisk. It also goes by the name NovoRapid

[marionbarker]

I still think this is horribly confusing. There is an Insulin Type selected in Pump; Insulin Curve selected in Preferences and then this. And what the heck is bi-linear (Insulin Curve in preferences)?

Also the exponential model (for rapid-acting and ultra-rapid) has 3 parameters - this is only changing one.

What about something like this, where you make sure the limits are right and fix the {pump/insulin curve} section:

Custom adjustment for time of maximum blood glucose lowering effect of insulin, in minutes. Most people should use the insulin model as selected in {the pump or preferences: Insulin curve}. If custom adjustment is desired, limit the range to be no shorter than 35 minutes and no longer than 120 minutes. Using a custom insulinPeakTime outside these bounds will result in issues with Trio, longer loop calculations and possible red loops.

[dnzxy]

To answer this in short: the insulin curve setting can be deleted, it’s useless. Insulin is selected via pump manager UI from LoopKit.

The text reads good!

[mountrcg]

Btw, if we could apply the boundary concept to this it would help a lot. I had raised an issue with oref at the time. Thetry to fix it in oref went not ok and raised other issues, so no solution there yet. However I guess that needs splitting peak time into 3 peak times for the three insulin models.