Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete team and app #215

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Delete team and app #215

merged 9 commits into from
Oct 15, 2024

Conversation

dzlk17
Copy link

@dzlk17 dzlk17 commented Oct 11, 2024

No description provided.

@dzlk17 dzlk17 changed the base branch from main to analytics-sdk October 11, 2024 11:36
Giems
Giems requested changes Oct 11, 2024
View reviewed changes
server/src/http/cloud/delete_app.rs Outdated Show resolved Hide resolved
server/src/http/cloud/delete_app.rs Outdated Show resolved Hide resolved
server/src/http/cloud/delete_app.rs Outdated Show resolved Hide resolved
server/src/http/cloud/delete_team.rs Outdated Show resolved Hide resolved
server/src/http/cloud/delete_team.rs Outdated Show resolved Hide resolved
server/src/http/cloud/grafana_utils/delete_registered_app.rs Outdated Show resolved Hide resolved
server/src/http/cloud/grafana_utils/delete_team.rs Outdated Show resolved Hide resolved
server/src/http/cloud/grafana_utils/delete_team.rs Outdated Show resolved Hide resolved
server/src/http/cloud/grafana_utils/delete_team.rs Outdated Show resolved Hide resolved
server/src/http/cloud/grafana_utils/delete_team.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview: https://connect-h69z7jsy9-nightlylabs.vercel.app

@github-actions GitHub Actions
Copy link

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview: https://connect-iucn7hja2-nightlylabs.vercel.app

@github-actions GitHub Actions
Copy link

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview: https://connect-563xul1ns-nightlylabs.vercel.app

@github-actions GitHub Actions
Copy link

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview: https://connect-md4l5al2k-nightlylabs.vercel.app

Giems
Giems reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@Giems Giems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do use .deactivated_at != None in a lot of places, which is kinda like a double negation. I'd suggest to use .deactivated_at.is_some() which is a lot easier to read

server/src/http/cloud/grafana_utils/delete_team.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview: https://connect-9h2o06ja0-nightlylabs.vercel.app

@github-actions GitHub Actions
Copy link

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview: https://connect-dp954narm-nightlylabs.vercel.app

@github-actions GitHub Actions
Copy link

🤙🤙🤙🤙 EXAMPLE PREVIEW 🤙🤙🤙🤙

✅ Preview: https://connect-8aw3bgja3-nightlylabs.vercel.app

@dzlk17 dzlk17 merged commit a936de5 into analytics-sdk Oct 15, 2024
2 of 3 checks passed
@dzlk17 dzlk17 deleted the delete_team_and_app branch October 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giems Giems Giems requested changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzlk17 @Giems