NIGH-153 Fix FilterComments Error (#41)

* fix bug caused by comments on outdated code * add outdated comment to test
nightfallai · Sep 3, 2020 · eed4e3a · eed4e3a
1 parent 3b54d0b
commit eed4e3a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/internal/clients/diffreviewer/circleci/circleci_service.go b/internal/clients/diffreviewer/circleci/circleci_service.go
@@ -281,18 +281,18 @@ func filterExistingComments(comments []*github.PullRequestComment, existingComme
 	existingCommentsMap := make(map[prComment]bool, len(existingComments))
 	for _, ec := range existingComments {
 		comment := prComment{
-			Body: *ec.Body,
-			Path: *ec.Path,
-			Line: *ec.Line,
+			Body: ec.GetBody(),
+			Path: ec.GetPath(),
+			Line: ec.GetLine(),
 		}
 		existingCommentsMap[comment] = true
 	}
 	filteredComments := make([]*github.PullRequestComment, 0, len(comments))
 	for _, c := range comments {
 		comment := prComment{
-			Body: *c.Body,
-			Path: *c.Path,
-			Line: *c.Line,
+			Body: c.GetBody(),
+			Path: c.GetPath(),
+			Line: c.GetLine(),
 		}
 		if _, ok := existingCommentsMap[comment]; !ok {
 			filteredComments = append(filteredComments, c)

diff --git a/internal/clients/diffreviewer/circleci/circleci_service_test.go b/internal/clients/diffreviewer/circleci/circleci_service_test.go
@@ -444,6 +444,11 @@ func (c *circleCiTestSuite) TestFilterExistingComments() {
 			Path: &pathStrs[2],
 			Line: &lineNums[2],
 		},
+		{
+			Body: &bodyStrs[0],
+			Path: &pathStrs[0],
+			Line: nil,
+		},
 	}
 	newComment1 := &github.PullRequestComment{
 		Body: &bodyStrs[0],