Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build due to relocated libjpeg-turbo repository #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,14 @@ You can download nidium binaries for Linux and OSX from the [download page](http

## Building nidium

To build nidium you need at least 5.7GB of disk space. A build from scratch may take 30 to 90 minutes, depending of the speed of your computer.
To build nidium you need:
- at least 5.7GB of disk space.
- an account on *.googlesource.com (https://skia.googlesource.com/new-password)
You will be prompted to login during the `./configure_frontend` step.

On a debian based system, a few commands will get you started.
A build from scratch may take 30 to 90 minutes, depending of the speed of your computer.

### On a debian based system, a few commands will get you started.

```
$ apt-get install libpci-dev python2.7 git make patch clang pkg-config libgtk2.0-dev libgtk-3-dev mesa-common-dev libglu1-mesa-dev libosmesa6-dev yasm libasound2 libasound2-dev libbz2-1.0
Expand All @@ -78,7 +83,7 @@ $ ./configure_frontend
$ ./bin/nidium
```

On a mac-os based system you need xcode installed.
### On a mac-os based system you need xcode installed.

```
sudo xcode-select -s /Applications/Xcode.app/Contents/Developer
Expand Down
9 changes: 9 additions & 0 deletions configure_frontend
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,13 @@ def skia():
"-Wno-unused-template",
"-Wno-zero-as-null-pointer-constant",
"-Wno-expansion-to-defined",

"-Wno-null-pointer-arithmetic",
"-Wno-redundant-parens",
"-Wno-return-std-move-in-c++11",
"-Wno-self-assign-overloaded",
"-Wno-tautological-type-limit-compare",
"-Wno-tautological-unsigned-enum-zero-compare",
"-DGR_GL_CUSTOM_SETUP_HEADER=<../../../../../patch/skia_gl_config.h>"
],
"is_official_build": True,
Expand Down Expand Up @@ -150,6 +157,8 @@ def skia():
return {
"location": Deps.GitRepo("https://skia.googlesource.com/skia.git", branch="chrome/m58"),
"build": [
'''sed -i.bak -e 's/third_party\/libjpeg-turbo\.git@.*/external\/github.com\/libjpeg-turbo\/[email protected]",/' DEPS''',
"cd ./third_party/externals/libjpeg-turbo && autoreconf -fiv && ./configure && cd -",
"python tools/git-sync-deps",
"bin/gn gen out/Static --args='%s'" % (skiaArgs),
"sed -i.bak '/simpleperf/d' out/Static/build.ninja",
Expand Down