Escape \X in stylesheets

nicpillinger · Oct 12, 2013 · 02f4461 · 02f4461
1 parent 9408a46
commit 02f4461
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/lib/pdfkit/pdfkit.rb b/lib/pdfkit/pdfkit.rb
@@ -105,7 +105,7 @@ def append_stylesheets
 
       stylesheets.each do |stylesheet|
         if @source.to_s.match(/<\/head>/)
-          @source = Source.new(@source.to_s.gsub(/(<\/head>)/, style_tag_for(stylesheet)+'\1'))
+          @source = Source.new(@source.to_s.gsub(/(<\/head>)/) {|s| style_tag_for(stylesheet) + s })
         else
           @source.to_s.insert(0, style_tag_for(stylesheet))
         end

diff --git a/spec/fixtures/example_with_hex_symbol.css b/spec/fixtures/example_with_hex_symbol.css
@@ -0,0 +1,3 @@
+.test:before {
+    content: '\2039';
+}
diff --git a/spec/pdfkit_spec.rb b/spec/pdfkit_spec.rb
@@ -203,6 +203,14 @@
       pdfkit.source.to_s.should include("<style>#{File.read(css)}</style></head>")
     end
 
+    it "should escape \\X in stylesheets" do
+      pdfkit = PDFKit.new("<html><head></head><body>Hai!</body></html>")
+      css = File.join(SPEC_ROOT,'fixtures','example_with_hex_symbol.css')
+      pdfkit.stylesheets << css
+      pdfkit.to_pdf
+      pdfkit.source.to_s.should include("<style>#{File.read(css)}</style></head>")
+    end
+
     it "should throw an error if it is unable to connect" do
       pdfkit = PDFKit.new("http://google.com/this-should-not-be-found/404.html")
       lambda { pdfkit.to_pdf }.should raise_error