forked from omz/AppSales-Mobile
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscriptions #65
Open
ddaddy
wants to merge
13
commits into
nicolasgomollon:master
Choose a base branch
from
ddaddy:subscriptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Subscriptions #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can sometimes be tricky to hit the long press on the accessory view. Now you can long press anywhere on the row to access the advanced mode options.
This PR now also fixes Payment downloads as per #66 |
I've also added to this the ability to disable downloading on a per account basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now filter the view by New Subscriptions and Subscription Renewals.
Each category will show either number of units, or revenue.
Because the new
Subscription
class is added to each report as it's downloaded, it will only show for newly downloaded reports, so I have also added aRecalculate Sales Cache
button to the account settings.Recalculating Sales Cache will loop through every report, pull out the original CSV, create a new report from the CSV, copy the original CSV over to the new report, then delete the old report.
I've tested this numerous times and compared results with data from a previous version and i've not come across any errors.
So on first use of this new version, hit the Recalculate Sales Cache button and enjoy.
Additionally, this PR fixes some UI issues with the toolbar and also corrects the fiscal calendar which was wrong for December 2022 and possibly the whole of 2022. The old rule of every 5 years doesn't seem to hold true any longer.
I have had to manually add the 5 week periods where needed.