Code Review Changes

nicoco007 · Jul 15, 2021 · 7a02ba9 · 7a02ba9
1 parent 4a77314
commit 7a02ba9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/Shared/PlaylistManager.cs b/Shared/PlaylistManager.cs
@@ -809,18 +809,7 @@ public void StorePlaylist(IPlaylist playlist, IPlaylistHandler playlistHandler,
             if (string.IsNullOrEmpty(fileName))
             {
                 // Generate Name
-                fileName = string.Join("_", playlist.Title
-                    .Replace("/", "")
-                    .Replace("\\", "")
-                    .Replace(".", "")
-                    .Replace(":", "")
-                    .Replace("*", "")
-                    .Replace("?", "")
-                    .Replace("\"", "")
-                    .Replace("<", "")
-                    .Replace(">", "")
-                    .Replace("|", "")
-                    .Split());
+                fileName = string.Join("_", string.Join("", playlist.Title.Split(Path.GetInvalidFileNameChars(), StringSplitOptions.RemoveEmptyEntries)).Split());
                 if (string.IsNullOrEmpty(fileName))
                 {
                     fileName = "playlist";

diff --git a/Shared/Types/Playlist.cs b/Shared/Types/Playlist.cs
@@ -162,7 +162,7 @@ public IPlaylistSong this[int index]
         public int Count => Songs.Count;
 
         /// <inheritdoc/>
-        public virtual bool IsReadOnly => false;
+        public virtual bool IsReadOnly => ReadOnly;
 
         /// <summary>
         /// Creates a new <see cref="IPlaylistSong"/> of type <typeparamref name="T"/> from the given <paramref name="song"/>.