[Bug Fix] Fix the issue that current item index may be changed after rotation #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, if this is merged, can you release a new version to Cocoapods? Thanks! |
flexme
changed the title
|
Nick, can you merge this? We need it and the updated cocoapods to fix the bug in our app. Thanks! |
|
Hmm, is this project still being maintained? |
michafaw
approved these changes
Sep 26, 2016
|
For me this fixed the problem when rotating from landscape to portrait while on the last item. But the bug can still be reproduced when rotating from portrait to landscape while on the last item. (Iphone SE,7,7+). It jumps to the second to last item. Any suggestions? |
|
It hurts to see this amazing library no longer mantained, tbh. |
|
@AlexAstilean this workaround works well for my usecase: http://pastebin.com/tHPaqsaN |
dimovskidamjan
pushed a commit
to dimovskidamjan/SwipeView
that referenced
this pull request
Feb 24, 2017
Fixes an issue where current item index was being changed on device rotation.
dimovskidamjan
added a commit
to dimovskidamjan/SwipeView
that referenced
this pull request
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #200 .
Basically when the device is rotated, the scroll view's contentSize may be changed since itemSize may be changed (by method
updateScrollViewDimensions). However changingcontentSizewill result incontentOffsetbeing changed by UIKit, thenScrollView.scrollViewDidScrollwill be invoked and change the current item index...This fix ensures that we update the contentOffset based on current item index when contentSize is changed.