Update redundantClosure rule to preserve closure where if/switch expression would not be allowed
#1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on would not be allowed
calda
commented
Oct 15, 2023
| @@ -1822,6 +1822,11 @@ class ParsingHelpersTests: XCTestCase { | |||
| XCTAssert(isSingleExpression(#"#selector(Foo.bar)"#)) | |||
| XCTAssert(isSingleExpression(#"#macro()"#)) | |||
| XCTAssert(isSingleExpression(#"#outerMacro(12, #innerMacro(34), "some text")"#)) | |||
| XCTAssert(isSingleExpression(#"try { try printThrows(foo) }()"#)) | |||
There was a problem hiding this comment.
This previously failed to parse as a single expression
Codecov Report
@@ Coverage Diff @@
## develop #1553 +/- ##
===========================================
+ Coverage 94.96% 94.98% +0.02%
===========================================
Files 20 20
Lines 21670 21738 +68
===========================================
+ Hits 20578 20648 +70
+ Misses 1092 1090 -2
|
|
Thanks so much Cal ❤️ |
|
Happy to heelllppp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
redundantClosurerule to preserve closures with if/switch expressions if the closure is in a position where an if/switch expression would not be allowed. In Swift 5.9 if/switch expressions are only allowed as either return values, or as the result of an assignment.This PR also fixes miscellaneous issues where
redundantClosuredidn't properly handle some combinations of explicitreturn,try/await, and if/switch expressions.Fixes #1547 and #1548.