Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIImages are now created with a default retina scale #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikelovesrobots
Copy link

As of iOS7, all devices sold are retina, so it makes sense to transition to loading all the images with the proper scale. This makes it possible when using UIImageViews to use the more interesting view modes like top-left, bottom-right, etc.

If you merge this directly, you'll break the code of people who depended on the old behavior. You might want to make it configurable with the default being 2.0.

[edit] It's not true about all ios7 devices being retina. See comment by bastionhoyer below.

@bastianh
Copy link

bastianh commented Oct 2, 2013

ipad mini is not yet retina and might get delayed until 2014

@mikelovesrobots
Copy link
Author

Interesting. Anyway, we found it confusing to work with UIImages from the web at scale 1 in our app. Maybe it should be configurable.

@fraserscottmorrison
Copy link

So how can I use this library to load a retina image from a url? The image scale should definitely be configurable now!

@fantattitude
Copy link

Wouldn't it be more interesting to add the ability to look for @2x and @3x images if the device is detected as not having the legacy scale ?
This way nothing is broken for people relying to the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants