Add Molecule Tests #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test against centos:7 * test against centos:6 * test against ubuntu:18.04 * test against ubuntu:16.04 * test against ubuntu:14.04 * fix linting issues
* remove Vagrant tests * update docs
also turn python back on
The incorrect logrotate options triggered a failed travis-ci build as expected. I also updated the versions of Ubuntu and CentOS in the meta file to match what the tests run against.
One of the things this disables is the long line check. This means the `->` used in `.travis.yml` could be made into a single line. I'm leaving it as multiline because I think it is more readable.
Following a pattern I learned from geelingguy I am attempting to create a more accurate test of this role on different distributions.
I also reduced the MATRIX to make it fail cheaper
|
After taking a look @geerlingguy ansible-role-ansible I realized my original test was testing running the same docker image on different operating systems. What I wanted to test is the role on docker containers running different operating systems (duh). This PR now does that. I also realize my learning curve with TravisCI is showing in the number of commits in this PR. If you are need me to squash them please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds molecule tests and removed the Vagrant based tests. It also updates
.travis.ymto run the new tests.To run the tests, install molecule (in a virtualenv works fine with python 2.7) and then run
molecule testfrom the root of the repo.The tests were written with the Docker driver to improve compatibility with CI.
To see the results of the tests, you can go to https://travis-ci.org/rcuza/ansible-logrotate. Test number 6 was an intentional failed build so you can see how it catches errors.
Thank you for making your original code available.