adding Tests for dealing with NA in construct_label #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know what went wrong with the test there. maybe something with package versions? because the test itself passed. |
|
and I was wondering, how missing standard errors should be represented best - but maybe that's not very urgent. |
|
Content is great, the checks fail due to a breaking change in the |
Merge remote-tracking branch 'origin' into NAtest_construct_label # Bitte geben Sie eine Commit-Beschreibung ein, um zu erklären, warum dieser # Merge erforderlich ist, insbesondere wenn es einen aktualisierten # Upstream-Branch mit einem Thema-Branch zusammenführt. # # Zeilen, die mit '#' beginnen, werden ignoriert, # und eine leere Beschreibung bricht den Commit ab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a test for consruct_label() to see whether NAs are correlcty converted to empty strings.
@nickhaf I noticed that I created the data frame differently in the example than you created them in the other tests. The way you did it, the function actually merges est and se, in the current examples, it creates a new column - so I'm going to change that, to that it actually merges them into a new label.