direnv: allow adding additional files to watch #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
reviewed
Dec 17, 2023
| @@ -16,7 +23,7 @@ | |||
| if ! has nix_direnv_version || ! nix_direnv_version 2.4.0; then | |||
| source_url "https://raw.githubusercontent.com/nix-community/nix-direnv/2.4.0/direnvrc" "sha256-XQzUAvL6pysIJnRJyR7uVpmUSZfc7LSgWQwq/4mBr1U=" | |||
| fi | |||
| nix_direnv_watch_file project.ncl nickel.lock.ncl | |||
| nix_direnv_watch_file project.ncl nickel.lock.ncl %{std.string.join " " direnv.watch_files} | |||
There was a problem hiding this comment.
Shouldn't we escape the file names here, in all generality? For example:
let escape = std.string.replace "\"" "\\\"" in
let enclose = fun s => "\"%{s}\"" in
let extra_watch_files =
direnv.watch_files
|> std.array.map (fun s => s |> escape |> enclose)
|> std.string.join " "
in
..
nix_direnv_watch_file project.ncl nickel.lock.ncl extra_watch_files
There was a problem hiding this comment.
I'm assuming this is for and other special characters? Perhaps we should use single quotes (') in the enclose function to also avoid arbitrary command expansions?
There was a problem hiding this comment.
Right, ' is probably better (then we need to escape them instead of " in escape)
There was a problem hiding this comment.
@nrdxp are you still willing to apply this change? I think after that this PR is good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.