Move checks to project.ncl #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear if we need to implement runCommand ourselves, it's quite simple to achieve necesary result with plaing NixpkgsPkg override. Introduce NixEnvironmentVariable contract to handle all possible things than might end up in `env`. Part of #58.
YorikSar
force-pushed
the
nickel-checks
branch
from
a95a040
to
5a7c295
Compare
|
@thufschmitt Since #153 is blocked on Nickel issue, should we roll this back to using the big contract on Nickel side to move the rest of the chain forward? |
|
Yes you're right, let's do that for the time being |
YorikSar
force-pushed
the
nickel-checks
branch
from
5a7c295
to
a95a040
Compare
thufschmitt
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear if we need to implement runCommand ourselves, it's quite simple to achieve necesary result with plaing NixpkgsPkg override.
Introduce NixEnvironmentVariable contract to handle all possible things than might end up in
env.Part of #58.